-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACT-688 Renamed beneficiary model to Individual #330
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #330 +/- ##
==========================================
+ Coverage 50.37% 50.42% +0.05%
==========================================
Files 101 103 +2
Lines 8320 8329 +9
==========================================
+ Hits 4191 4200 +9
Misses 4129 4129
Continue to review full report at Codecov.
|
@Kimaiyo077 can you kindly review this when you have time? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nasirhjafri Please fix failing tests, The migrations are the issue here.
done! |
@nasirhjafri it looks like we nee dto run migrations again, the tests are failing |
Hey @nasirhjafri, Nice work on the changes you made and ensuring everything is as before. I, however, have found one issue. When I try to change the Individuals label to my own organization label, I am unable to save it. To reproduce the error go to organization settings, under configurations labels you will find form library labels and try to update any. |
@nasirhjafri @Kimaiyo077 Do we know if the |
If I remember correctly, It was done before and I could change the labels for the form library components. I, however, would suggest that this issue be moved to a separate card seeing as this one is already large enough. This one issue can be fixed in a new ticket |
Hi @nasirhjafri I faced this issue when I tried to edit an individual record by either clicking on the individual's name I created OR click more > @Kimaiyo077 did you receive this when you tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ability to edit an Individual record is now working. Thanks @nasirhjafri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, migrations are now fixed!
What is the Purpose?
Briefly describe what the PR addresses
What was the approach?
Briefly describe the approach used to address the issue
Are there any concerns to addressed further before or after merging this PR?
State some additional info if any. For instance running
install
or setting some environment variable(s)Mentions?
Mention persons you'd like to review this PR
Issue(s) affected?
List of issues addressed by this PR.